Remove Elemental Devastation from spellcrit - #455
Open
Alessandro-Barbieri wants to merge 3 commits into
Open
Conversation
Elemental Devastation gives melee+ranged crit
Removed SpellCrit entries from Constants.lua.
wow API now consider the spellcrit from auras
BreakBB
reviewed
Aug 7, 2026
Comment on lines
-292
to
-293
| [51466] = 3, -- Elemental Oath Rank 1 | ||
| [51470] = 5, -- Elemental Oath Rank 2 |
Contributor
Author
There was a problem hiding this comment.
It was kept because I were not sure the game accounted for Apply Area Aura: Mod Spell Crit %
Now I checked with moonkin aura and ECS counts the buff twice, so it's very likely accounted twice too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elemental Devastation gives melee+ranged crit